deps: bump up googletest to v1.17.0 #39301
Conversation
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
|
theres been a few attempts at updating this one iirc - cc @asedeno (iirc you looked at this last) |
|
/retest |
|
/retest |
1 similar comment
|
/retest |
|
@agrawroh this PR is missing many changes I found I needed when attempting to update GoogleTest; look over #36699 to find some useful commits and shortcircuit figuring out what's broken via CI. I tried to keep each commit scoped to a particualr kind of change and with meaningful commit messages to make them easier to understand. |
|
I have cloned your PR in #39305 trying to help with the build. I think clang build may be ok, will see if gcc is happy. It may need to have some test files broken up into smaller pieces. |
agrawroh
force-pushed
the
deps-gtest
branch
2 times, most recently
from
983da0b to
6dc2b06
Compare
agrawroh
force-pushed
the
deps-gtest
branch
2 times, most recently
from
ff2dc5f to
41b06ef
Compare
test/test_runner.cc
Outdated
| @@ -90,7 +92,7 @@ int TestRunner::runTests(int argc, char** argv) { | |||
|
|
|||
| // Use the recommended, but not default, "threadsafe" style for the Death Tests. | |||
| // See: https://github.com/google/googletest/commit/84ec2e0365d791e4ebc7ec249f09078fb5ab6caa | |||
| ::testing::FLAGS_gtest_death_test_style = "threadsafe"; | |||
| GTEST_FLAG_SET(death_test_style, "threadsafe"); | |||
There was a problem hiding this comment.
You can move this before listener is created and avoid the need to change listener.
agrawroh
force-pushed
the
deps-gtest
branch
3 times, most recently
from
4063e2f to
edffd9c
Compare
|
CC @envoyproxy/coverage-shephards: FYI only for changes made to |
agrawroh
force-pushed
the
deps-gtest
branch
2 times, most recently
from
7a96e62 to
da68e21
Compare
Signed-off-by: Rohit Agrawal <[email protected]>
agrawroh
force-pushed
the
deps-gtest
branch
2 times, most recently
from
fef21da to
b2f60a6
Compare
Signed-off-by: Rohit Agrawal <[email protected]>
|
Closing this in favor of @yanavlasov's PR here which is clean and have all checks passing! |
Description
This PR bumps up the version of
googletestto v1.17.0Commit Message: deps: bump up googletest to v1.17.0
Additional Description: Bump up the version of
googletestto v1.17.0Risk Level: Low
Testing: CI
Docs Changes: N/A
Release Notes: N/A