-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Add SSE style message framing for streamed responses #39325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
The Envoy/Prechecks are failing in |
its a very annoying flake - i take full responsibility - but the tool is badly coded and badly cached ... such that if it caches failure you cant easily recache - still worth a try ... /retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm api
thanks @numanelahi !
/assign @nezdolik as grpc_json_transcoder code owner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated release date required
Signed-off-by: numanelahi <[email protected]>
Signed-off-by: numanelahi <[email protected]>
/retest |
Commit Message: Add SSE style message framing for streamed responses
Additional Description: This PR adds Server Side Events(SSE) style message framing for the streamed responses transcoded by the gRPC JSON transcoder. Before this the responses were streamed either as JSON array or as NDJSON.
Risk Level: low
Testing: Added unit tests for the feature
Docs Changes: Add details about the new config param for this feature.
Release Notes: Added to the change log.
Platform Specific Features: n/a