ext_proc: buffered mode is not sending local reply with large request #39345
Conversation
Signed-off-by: Yanjun Xiang <[email protected]>
yanjunxiang-google
requested review from
tyxia,
mattklein123 and
yanavlasov
as code owners
Signed-off-by: Yanjun Xiang <[email protected]>
Signed-off-by: Yanjun Xiang <[email protected]>
|
/retest |
|
/assign @tyxia @stevenzzzz @yanavlasov |
| @@ -743,6 +743,9 @@ FilterDataStatus Filter::onData(ProcessorState& state, Buffer::Instance& data, b | |||
| // StopIterationAndWatermark as well to stop the ActiveStream from returning error when the | |||
| // last chunk added to stream buffer exceeds the buffer limit. | |||
| state.setPaused(true); | |||
| if (state.bodyMode() == ProcessingMode::BUFFERED) { | |||
There was a problem hiding this comment.
Can we add some comment here why this special treatment. I think it makes sense in most scenarios, that in happy path, we will buffer the body anyway, so no need to wait for header-response.
But in the rare case that header-response terminates the request already: error, body overrides, we may want to do some clarification here that this branch buffers unnecessarily.
There was a problem hiding this comment.
For BUFFERED mode, the API definition is "
// Buffer the message body in memory and send the entire body at once.
// If the body exceeds the configured buffer limit, then the
// downstream system will receive an error.
"
This is regardless how the ext_proc server response will be.
There was a problem hiding this comment.
Updated the comments.
|
I tested the fix and could no longer reproduce the behavior 👍 |
Signed-off-by: Yanjun Xiang <[email protected]>
…envoyproxy#39345) When Envoy is waiting for header response, and new client data arrives Envoy, Envoy should just buffer the data without raising watermarks. Raising watermarks is causing Envoy not sending local reply when the buffer size over the per-connection-limit. Fixes: envoyproxy#39365 --------- Signed-off-by: Yanjun Xiang <[email protected]> Signed-off-by: Ting Pan <[email protected]>
When Envoy is waiting for header response, and new client data arrives Envoy, Envoy should just buffer the data without raising watermarks. Raising watermarks is causing Envoy not sending local reply when the buffer size over the per-connection-limit.
Fixes: #39365