socket: include network namespace in proto translation #41814
+30
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jronak Thanks for the contribution! Could you please sign-off your commit to make DCO happy? |
Summary: Admin `/listeners` endpoint does not return the network namespace path of the listener sockets. This pull request updates the utilities used by listener handler to include network namespace path in the proto address returned in the response. This is used in production used for setting up sockets per network namespace and monitoring. Signed-off-by: Ronak Jain <[email protected]>
Signed-off-by: Ronak Jain <[email protected]>
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Admin
/listenersendpoint does not return the network namespace path of the listener sockets. This pull request updates the utilities used by listener handler to include network namespace path in the proto address returned in the response. This is used in production for setting up sockets per network namespace and monitoring.Additional Description: NA
Risk Level: Low
Testing: Unit test
Docs Changes: NA
Release Notes: NA
Platform Specific Features: NA