-
Notifications
You must be signed in to change notification settings - Fork 5.2k
admin: add group-based logging control #42517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @MayorFaj, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
|
CC @envoyproxy/coverage-shephards: FYI only for changes made to |
Signed-off-by: MayorFaj <[email protected]>
Add three additional high-value logger groups for comprehensive debugging: - stats: Statistics/metrics system debugging - runtime: Runtime configuration and feature flags - secret: Secret/credential management Signed-off-by: MayorFaj <[email protected]>
…andler test: enhance log level assertions for admin group in logs_handler_test Signed-off-by: MayorFaj <[email protected]>
- Fix line breaking in logger groups initialization - Fix comment spacing to follow style guide - Adjust ENVOY_LOG call formatting Signed-off-by: MayorFaj <[email protected]>
4c9f64d to
fff2a14
Compare
|
Waiting on the triggers to pass. /wait |
are the test flaky, or do I need to do anything to fix this? |
|
/retest |
|
Assigning @botengyao as the creator of the issue (#42434). |
Signed-off-by: Mayowa Fajobi <[email protected]>
If you click through on the envoy/checks or envoy/prechecks workflow (several clicks deep unfortunately) you can find what tests failed. Given that these tests are related to the changes you're making it's almost certainly related to your changes, not test flakes. /wait |
Commit Message:
Added support for group-based logging control via the
/loggingadmin endpoint. Users can now change log levels for predefined groups of loggers using/logging?group=<group_name>:<level>(e.g.,/logging?group=http:trace). This feature requires fine-grain logging to be enabled and simplifies debugging by allowing log level changes for entire subsystems with a single command instead of manually specifying individual file patterns.Implemented 16 predefined logger groups covering major Envoy subsystems: http, router, network, upstream, connection, admin, config, grpc, filter, listener, tls, quic, tracing, stats, runtime, and secret. Each group maps to relevant source file patterns, allowing comprehensive debugging of specific components.
Additional Description:
This PR addresses the feature request in #42434 to add group-based logging support. The implementation includes:
LogsHandler::getLoggerGroups()The groups cover frequently debugged areas including networking (http, network, connection, quic, tls), routing (router, upstream), configuration (config, runtime, secret), and observability (stats, tracing, admin, grpc).
Risk Level: Low
Small feature addition that extends existing logging functionality without changing core behavior.
Testing:
logs_handler_test.cccovering:Docs Changes:
source/server/admin/admin.ccRelease Notes:
Added to
changelogs/current.yamlunder admin section documenting the new feature and listing all 16 available groups.Platform Specific Features:
N/A
Fixes #42434