Skip to content

chore: remove useless val #5644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 10, 2025
Merged

chore: remove useless val #5644

merged 4 commits into from
Apr 10, 2025

Conversation

daixiang0
Copy link
Member

What type of PR is this?

Now we use IMAGE_PLATFORMS rather than IMAGE_PLAT

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Release Notes: Yes/No

@daixiang0 daixiang0 requested a review from a team as a code owner March 31, 2025 09:42
@daixiang0
Copy link
Member Author

root:[gateway]$ git grep IMAGE_PLAT
tools/make/common.mk:53:        IMAGE_PLAT := linux_$(GOARCH)
tools/make/common.mk:57:        IMAGE_PLAT := $(PLATFORM)
tools/make/image.mk:14:IMAGE_PLATFORMS ?= linux_amd64 linux_arm64
tools/make/image.mk:18:$(eval BUILDX_PLATFORMS = $(shell echo "${IMAGE_PLATFORMS}" | sed "s# #,#;s#_#/#g"))

Copy link

codecov bot commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.29%. Comparing base (52d8f9c) to head (5720b65).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5644      +/-   ##
==========================================
+ Coverage   65.27%   65.29%   +0.01%     
==========================================
  Files         213      213              
  Lines       34111    34111              
==========================================
+ Hits        22266    22272       +6     
+ Misses      10505    10499       -6     
  Partials     1340     1340              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arkodg arkodg requested a review from Xunzhuo April 9, 2025 21:23
@zirain zirain merged commit 67df5df into envoyproxy:main Apr 10, 2025
10 checks passed
@daixiang0 daixiang0 deleted the multi-build branch April 14, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants