Skip to content

feat(jwt): add local JWKS support for token validation #5670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 16, 2025

Conversation

zhaohuabing
Copy link
Member

@zhaohuabing zhaohuabing commented Apr 6, 2025

This PR allows using an inline string or a ConfigMap to specify the JWKS for token validation in the JWT section of a SecurityPolicy.

implements: #2419

Release note: yes.

@zhaohuabing zhaohuabing requested a review from a team as a code owner April 6, 2025 09:40
@zhaohuabing zhaohuabing marked this pull request as draft April 6, 2025 09:40
@zhaohuabing zhaohuabing force-pushed the local_jwks branch 5 times, most recently from 8f4525b to 76ae9c6 Compare April 7, 2025 07:54
@zhaohuabing zhaohuabing changed the title feat: add local JWKS support for JWT feat(jwt): add local JWKS support for token validation Apr 7, 2025
@zhaohuabing zhaohuabing force-pushed the local_jwks branch 2 times, most recently from 5b44cee to 89ff489 Compare April 7, 2025 09:06
@zhaohuabing zhaohuabing marked this pull request as ready for review April 7, 2025 09:13
@zhaohuabing zhaohuabing marked this pull request as draft April 7, 2025 09:13
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 62.50000% with 60 lines in your changes missing coverage. Please review.

Project coverage is 65.20%. Comparing base (40fc25d) to head (1299782).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
internal/provider/kubernetes/controller.go 0.00% 19 Missing ⚠️
internal/provider/kubernetes/indexers.go 9.52% 18 Missing and 1 partial ⚠️
internal/gatewayapi/securitypolicy.go 84.21% 7 Missing and 2 partials ⚠️
internal/provider/kubernetes/predicates.go 36.36% 5 Missing and 2 partials ⚠️
internal/xds/translator/jwt.go 88.46% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5670      +/-   ##
==========================================
- Coverage   65.21%   65.20%   -0.02%     
==========================================
  Files         214      214              
  Lines       34321    34426     +105     
==========================================
+ Hits        22384    22446      +62     
- Misses      10584    10626      +42     
- Partials     1353     1354       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zhaohuabing zhaohuabing force-pushed the local_jwks branch 2 times, most recently from 2d9957d to 4960b92 Compare April 7, 2025 10:57
@zhaohuabing zhaohuabing marked this pull request as ready for review April 7, 2025 12:16
@zhaohuabing zhaohuabing marked this pull request as draft April 7, 2025 12:18
@zhaohuabing zhaohuabing force-pushed the local_jwks branch 3 times, most recently from dc81c63 to 54a2ebc Compare April 8, 2025 02:08
@zhaohuabing zhaohuabing marked this pull request as ready for review April 8, 2025 03:00
@zhaohuabing zhaohuabing requested a review from a team April 8, 2025 05:07
Co-authored-by: Arko Dasgupta <[email protected]>
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
@zhaohuabing zhaohuabing requested a review from arkodg April 10, 2025 03:16
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
@zhaohuabing zhaohuabing requested review from a team April 11, 2025 03:22
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team April 14, 2025 23:35
@arkodg arkodg merged commit 734679a into envoyproxy:main Apr 16, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants