fix: enable http3 panic #5671
Open
fix: enable http3 panic #5671
+184
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bitliu <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5671 +/- ##
==========================================
+ Coverage 65.20% 65.29% +0.08%
==========================================
Files 213 213
Lines 34108 34115 +7
==========================================
+ Hits 22241 22276 +35
+ Misses 10521 10500 -21
+ Partials 1346 1339 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zhaohuabing
reviewed
Apr 8, 2025
internal/xds/translator/listener.go
Outdated
| if err := addXdsTLSInspectorFilter(xdsListener); err != nil { | ||
| return err | ||
| // Only add TLS inspector filter if the listener is not nil and is a TCP listener | ||
| if xdsListener != nil && xdsListener.GetAddress().GetSocketAddress().GetProtocol() == corev3.SocketAddress_TCP { |
There was a problem hiding this comment.
I think we should also not add ServerNameMatch for UDP/HTTP3.
|
Is this related to #5005? |
Yes, |
Signed-off-by: bitliu <[email protected]>
arkodg
reviewed
Apr 9, 2025
| @@ -511,14 +511,20 @@ func buildEarlyHeaderMutation(headers *ir.HeaderSettings) []*corev3.TypedExtensi | |||
| } | |||
|
|
|||
| func addServerNamesMatch(xdsListener *listenerv3.Listener, filterChain *listenerv3.FilterChain, hostnames []string) error { | |||
| // Dont add a filter chain match if the hostname is a wildcard character. | |||
| // Don't add a filter chain match if the hostname is a wildcard character or if the listener is UDP (HTTP3) | |||
There was a problem hiding this comment.
would be easier to read if the skip is moved to the top
if xdsListener == nil || xdsListener.GetAddress().GetSocketAddress().GetProtocol() != corev3.SocketAddress_UDP
return nil
lamacorp-bot
pushed a commit
to LamaCorp/infra-infrastructure
that referenced
this pull request
Apr 17, 2025
Signed-off-by: Marc 'risson' Schmitt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
These changes ensure that when HTTP/3 is enabled through a ClientTrafficPolicy, the TLS inspector filter is only added to TCP listeners, not to UDP (QUIC) listeners, which prevents the nil pointer dereference.
Which issue(s) this PR fixes:
Fixes #5660
Release Notes: Yes/No