api: support per-route tracing #5672
Open
+209
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5672 +/- ##
==========================================
+ Coverage 65.19% 65.22% +0.02%
==========================================
Files 214 214
Lines 34321 34321
==========================================
+ Hits 22377 22386 +9
+ Misses 10591 10582 -9
Partials 1353 1353 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arkodg
reviewed
Apr 9, 2025
| @@ -31,6 +31,8 @@ type ProxyTracing struct { | |||
| SamplingFraction *gwapiv1.Fraction `json:"samplingFraction,omitempty"` | |||
| // CustomTags defines the custom tags to add to each span. | |||
| // If provider is kubernetes, pod name and namespace are added by default. | |||
| // | |||
There was a problem hiding this comment.
can we take SamplingRate, SamplingFraction and CustomTags, and put in into another struct which we can embed here and in BackendTelemetry ?
There was a problem hiding this comment.
I think we should move to use SamplingFraction and deprecate SamplingRate in the future.
RDS support FractionalPercent directly, so I don't want another convertion here.
There was a problem hiding this comment.
cool, can you create a embedded struct inside Tracing so SamplingFraction and CustomTags can be reused
arkodg
reviewed
Apr 9, 2025
arkodg
reviewed
Apr 9, 2025
zirain
force-pushed
the
btp-telemetry
branch
2 times, most recently
from
5265310 to
1126592
Compare
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: #5486