Skip to content

fix: httproute status.parents is not cleaned up #5679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Apr 7, 2025

What type of PR is this?

What this PR does / why we need it:

The fix ensures that the status.parents field accurately reflects the current state of the spec.parentRefs field.

Which issue(s) this PR fixes:

Fixes #5581

Release Notes: Yes/No

@Xunzhuo Xunzhuo requested a review from a team as a code owner April 7, 2025 06:05
@Xunzhuo Xunzhuo marked this pull request as draft April 7, 2025 08:03
@Xunzhuo Xunzhuo force-pushed the fix-status-clean branch 2 times, most recently from 193cbb2 to cbdb036 Compare April 7, 2025 09:55
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 82.85714% with 6 lines in your changes missing coverage. Please review.

Project coverage is 65.20%. Comparing base (e374db4) to head (a310cd0).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/provider/kubernetes/status.go 82.85% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5679      +/-   ##
==========================================
- Coverage   65.20%   65.20%   -0.01%     
==========================================
  Files         213      213              
  Lines       34108    34140      +32     
==========================================
+ Hits        22241    22261      +20     
- Misses      10521    10530       +9     
- Partials     1346     1349       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Xunzhuo Xunzhuo force-pushed the fix-status-clean branch from d8bb324 to a310cd0 Compare April 9, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All HTTPRoutes fail to resolve when a single route's SecurityPolicy fails to load
1 participant