Skip to content

docs: Added "ask a question" to side panel of each doc #5681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2025

Conversation

melsal13
Copy link
Collaborator

@melsal13 melsal13 commented Apr 7, 2025

What type of PR is this?
Docs change, added "ask a quesition" button to side panel of docs that links to Envoy gateway github discussions page.

What this PR does / why we need it:
Improves visibility of the github discussion forum.

Which issue(s) this PR fixes:
N/a

Release Notes: No

Copy link

codecov bot commented Apr 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.27%. Comparing base (f4a5d7e) to head (4f175f9).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5681      +/-   ##
==========================================
+ Coverage   65.23%   65.27%   +0.03%     
==========================================
  Files         213      213              
  Lines       34108    34108              
==========================================
+ Hits        22251    22264      +13     
+ Misses      10515    10505      -10     
+ Partials     1342     1339       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@@ -54,5 +54,6 @@
{{ with .CurrentSection.AlternativeOutputFormats.Get "print" -}}
<a id="print" href="{{ .RelPermalink | safeURL }}"><i class="fa-solid fa-print fa-fw"></i> {{ T "print_entire_section" }}</a>
{{ end }}
<a href="https://github.com/envoyproxy/gateway/discussions/new?category=q-a" class="td-page-meta--ask td-page-meta__ask" target="_blank" rel="noopener"><i class="fa-solid fa-question-circle fa-fw"></i> Ask a Question</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd perfer to guide users to the gateway-user slack channel, as handling questions across multiple platforms can be difficult to manage.

https://envoyproxy.slack.com/archives/C03E6NHLESV

WDYT @envoyproxy/gateway-maintainers

Copy link
Contributor

@missBerg missBerg Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhaohuabing i requested this because questions added to GitHub Q&A are:

  • indexed by search engines and helps other people find answers (when for example Googling)
  • accessible to people who are not using slack, I met a lot of people at KubeCon in London who prefer to ask questions outside of Slack

Negatives of Slack questions:

  • not searchable outside of slack
  • not ability to mark an answers as the correct answer to the question
  • not easily integrating directly to GitHub issues

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, that makes sense. Thanks!

@melsal13
Copy link
Collaborator Author

melsal13 commented Apr 9, 2025

ask-a-question

Ask a question button located under Print entire section button in the right side panel.

@arkodg
Copy link
Contributor

arkodg commented Apr 9, 2025

hey @melsal13 is this PR ready for review ?

@melsal13 melsal13 marked this pull request as ready for review April 9, 2025 18:18
@melsal13 melsal13 requested a review from a team as a code owner April 9, 2025 18:18
@melsal13
Copy link
Collaborator Author

melsal13 commented Apr 9, 2025

@arkodg Yup! Just changed the stage to ready for review.

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team April 9, 2025 21:07
Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@zirain zirain merged commit dcc6389 into envoyproxy:main Apr 10, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants