Skip to content

docs: Fix side navbar padding and scrolling issues #5686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

melsal13
Copy link
Collaborator

@melsal13 melsal13 commented Apr 7, 2025

What type of PR is this?
Fixes the overflow issue of the side navbar and also allows the user to finish scrolling the navbar before making the webpage scroll.

What this PR does / why we need it:
In our current site, the user needs to scroll all the way to the bottom of the webpage before being able to scroll to the bottom of the navbar. This PR makes it easier for a user to find what they are looking for.

Which issue(s) this PR fixes:
N/a

Release Notes: No

Copy link

codecov bot commented Apr 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.25%. Comparing base (521b78b) to head (025ac92).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5686      +/-   ##
==========================================
- Coverage   65.27%   65.25%   -0.02%     
==========================================
  Files         213      213              
  Lines       34108    34108              
==========================================
- Hits        22263    22258       -5     
- Misses      10503    10510       +7     
+ Partials     1342     1340       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zhaohuabing
Copy link
Member

@melsal13 Thanks for fixing this. Could you please paste the screenshots before/after the fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants