Support ServiceImport AppProtocol parsing #5687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Teju Nareddy <[email protected]>
Signed-off-by: Teju Nareddy <[email protected]>
Signed-off-by: Teju Nareddy <[email protected]>
Signed-off-by: Teju Nareddy <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5687 +/- ##
==========================================
+ Coverage 65.27% 65.31% +0.04%
==========================================
Files 213 213
Lines 34108 34111 +3
==========================================
+ Hits 22263 22281 +18
+ Misses 10503 10492 -11
+ Partials 1342 1338 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
cc @muwaqar |
Signed-off-by: Teju Nareddy <[email protected]>
|
/retest |
|
retest |
zirain
reviewed
Apr 8, 2025
Signed-off-by: Teju Nareddy <[email protected]>
zirain
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ServiceImport
appProtocolis currently not honored.Solution
This PR add support for the user to specify
appProtocol = kubernetes.io/h2cto configure xDS in H2 mode.As discussed in #5485 (comment), we will not support the legacy
grpcvalue. Onlykubernetes.io/h2cis supported forServiceImport.No changes are made to pre-existing behavior for
ServiceappProtocolparsing.Additional Info
Fixes #5485
Release Notes: Yes