provider: add missing predicates #5698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5698 +/- ##
==========================================
- Coverage 65.26% 65.25% -0.02%
==========================================
Files 213 213
Lines 34111 34104 -7
==========================================
- Hits 22263 22254 -9
- Misses 10507 10508 +1
- Partials 1341 1342 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arkodg
reviewed
Apr 9, 2025
| @@ -1225,8 +1225,7 @@ func (r *gatewayAPIReconciler) watchResources(ctx context.Context, mgr manager.M | |||
|
|
|||
| // Watch Gateway CRUDs and reconcile affected GatewayClass. | |||
| gPredicates := []predicate.TypedPredicate[*gwapiv1.Gateway]{ | |||
| predicate.Or(predicate.TypedGenerationChangedPredicate[*gwapiv1.Gateway]{}, | |||
| predicate.TypedLabelChangedPredicate[*gwapiv1.Gateway]{}), | |||
| metadataPredicate[*gwapiv1.Gateway](), | |||
There was a problem hiding this comment.
is annotation changed, needed for gw as well ?
There was a problem hiding this comment.
prefer to keep them consitants.
Signed-off-by: zirain <[email protected]>
cnvergence
approved these changes
Apr 10, 2025
arkodg
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: #5695