Feat: support mixed address types across BackendRefs in xRoute #5716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudrakhp
force-pushed
the
support_mixed_address_types_route
branch
2 times, most recently
from
b477879 to
461782f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5716 +/- ##
==========================================
- Coverage 65.19% 65.08% -0.12%
==========================================
Files 214 219 +5
Lines 34321 34839 +518
==========================================
+ Hits 22377 22674 +297
- Misses 10591 10779 +188
- Partials 1353 1386 +33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rudrakhp
force-pushed
the
support_mixed_address_types_route
branch
from
461782f to
cafd52c
Compare
arkodg
reviewed
Apr 14, 2025
Contributor
|
looks good @rudrakhp, thanks ! added one comment to improve my understanding of the code base |
rudrakhp
force-pushed
the
support_mixed_address_types_route
branch
2 times, most recently
from
92ce357 to
6aba619
Compare
Member
Author
|
Potential flake (run): |
Member
|
PR #5725 includes a major refactor of the HTTPRoute status logic. Would it be okay to wait until that's merged before moving forward with this one? Thanks! |
Contributor
|
hey @rudrakhp now that refactor is in, can you rebase ? |
rudrakhp
force-pushed
the
support_mixed_address_types_route
branch
2 times, most recently
from
d5c3903 to
eed3497
Compare
Signed-off-by: Rudrakh Panigrahi <[email protected]>
rudrakhp
force-pushed
the
support_mixed_address_types_route
branch
from
eed3497 to
1d45a6f
Compare
Member
Author
|
@arkodg rebased and moved some bits, also do let me know if the first comment is resolved. Thanks! |
guydc
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feat: support mixed address types across BackendRefs in xRoute
What this PR does / why we need it:
To support multiple address types across BackendRefs in xRoute, create XDS cluster per BackendRef.
Which issue(s) this PR fixes:
Related #5667
Release Notes: Yes/No