Skip to content

feat: implement offline kubernetes controller #5767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Apr 19, 2025

What type of PR is this?

What this PR does / why we need it:

impl offline controller detailed in #3213 (comment) and let file-provider to be able to utilise offline controller.

Which issue(s) this PR fixes:

fix #3213

Release Notes: Yes

@shawnh2 shawnh2 requested a review from a team as a code owner April 19, 2025 06:58
Copy link

codecov bot commented Apr 19, 2025

Codecov Report

Attention: Patch coverage is 44.37086% with 84 lines in your changes missing coverage. Please review.

Project coverage is 65.16%. Comparing base (096cb8d) to head (85f110d).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
internal/provider/kubernetes/controller_offline.go 0.00% 79 Missing ⚠️
internal/provider/kubernetes/indexers.go 93.05% 0 Missing and 5 partials ⚠️

❌ Your patch check has failed because the patch coverage (44.37%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5767      +/-   ##
==========================================
- Coverage   65.19%   65.16%   -0.04%     
==========================================
  Files         214      216       +2     
  Lines       34321    34654     +333     
==========================================
+ Hits        22377    22581     +204     
- Misses      10591    10691     +100     
- Partials     1353     1382      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zhaohuabing
Copy link
Member

zhaohuabing commented Apr 21, 2025

Hi @shawnh2 this PR adds the "offline controller," but it doesn’t include an example of how to actually use it. Since it's just a small change, could we also include the file provider modification as part of this PR to verify it works?

Thanks!

@shawnh2
Copy link
Contributor Author

shawnh2 commented Apr 21, 2025

Hi @shawnh2 this PR adds the "offline controller," but it doesn’t include an example of how to actually use it. Since it's just a small change, could we also include the file provider modification as part of this PR to verify it works?

Thanks!

sure, I was intend to include file provider in next PR. I will add it then.

@shawnh2 shawnh2 marked this pull request as draft April 26, 2025 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor the kubernetes provider to be provider-agnostic
2 participants