chart: adding extraVolumeMounts and extraVolumes fields to be mapped on the pods as volumes #5853
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mapped on the pods for eternal volumes, one of the cases is the unix volume mapping.
nnicora
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5853 +/- ##
==========================================
+ Coverage 65.31% 65.32% +0.01%
==========================================
Files 221 221
Lines 35314 35314
==========================================
+ Hits 23064 23068 +4
+ Misses 10825 10821 -4
Partials 1425 1425 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nnicora
changed the title
zirain
reviewed
Apr 29, 2025
| @@ -79,6 +79,18 @@ deployment: | |||
| topologySpreadConstraints: [] | |||
| tolerations: [] | |||
| nodeSelector: {} | |||
| # Additional volumeMounts on the deployment definition. | |||
| extraVolumeMounts: [] | |||
There was a problem hiding this comment.
I think we didn't the extra prefix, WDYT?
cc @envoyproxy/gateway-maintainers
There was a problem hiding this comment.
if we dont do the extra then we will need to expose the internal volumeMount here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Whenever wants the gateway to communicate with the extensions over the unix socket, the gateway have to be configured with the right existing socket directory path which should be mounted to the deployment.
Release Notes: No