chore: improve merge test #5861
Open
+154
−169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #5861 +/- ##
==========================================
- Coverage 65.41% 65.38% -0.03%
==========================================
Files 222 223 +1
Lines 35643 35645 +2
==========================================
- Hits 23315 23307 -8
- Misses 10882 10893 +11
+ Partials 1446 1445 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
arkodg
reviewed
Apr 30, 2025
| for _, mergeType := range []egv1a1.MergeType{egv1a1.StrategicMerge, egv1a1.JSONMerge} { | ||
| t.Run(fmt.Sprintf("%s/%s", mergeType, tc.name), func(t *testing.T) { | ||
| got, err := Merge[*egv1a1.BackendTrafficPolicy](tc.original, tc.patch, mergeType) | ||
| t.Run(fmt.Sprintf("%s/%s", mergeType, caseName), func(t *testing.T) { |
There was a problem hiding this comment.
testdata is currently flat, prefer current state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.