Skip to content

Conversation

@zirain
Copy link
Member

@zirain zirain commented May 10, 2025

fixes: #5962

@zirain zirain requested a review from a team as a code owner May 10, 2025 06:36
@codecov
Copy link

codecov bot commented May 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.50%. Comparing base (eb7266c) to head (c4af426).
Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5990      +/-   ##
==========================================
+ Coverage   70.48%   70.50%   +0.02%     
==========================================
  Files         219      219              
  Lines       36318    36318              
==========================================
+ Hits        25597    25605       +8     
+ Misses       9197     9191       -6     
+ Partials     1524     1522       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

config:
deploy:
# Deploy type controls which namespace EnvoyGateway will povison into.
# Optional value: ControllerNamespace, GatewayNamespace
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be inside provider.kubernetes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to add a knob won't be part of configmap, so that users can enabled rbac first and reenable GNM later.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

users will still need to then define twice, and the primary way to define configimap is via helm today

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either way is fine in this patch:

{{ if or $enabledInConfig $enabledInConfigmap }}

@zirain zirain force-pushed the gateway-namespace-mode-helm branch from b7cc28c to c4af426 Compare May 21, 2025 03:03
@zirain zirain closed this May 28, 2025
@zirain zirain deleted the gateway-namespace-mode-helm branch May 28, 2025 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better controls of ClusterRole of gateway namespace mode

2 participants