Skip to content

Conversation

@rudrakhp
Copy link
Member

@rudrakhp rudrakhp commented Nov 3, 2025

What type of PR is this?

fix: handle optional next update for crl

What this PR does / why we need it:
Allow valid CRLs with non-nil nextUpdate values. Note that only nextUpdate is optional while thisUpdate is mandatory according to RFC 5280:

CertificateList  ::=  SEQUENCE  {
        tbsCertList          TBSCertList,
        signatureAlgorithm   AlgorithmIdentifier,
        signatureValue       BIT STRING  }

   TBSCertList  ::=  SEQUENCE  {
        version                 Version OPTIONAL,
                                     -- if present, MUST be v2
        signature               AlgorithmIdentifier,
        issuer                  Name,
        thisUpdate              Time,
        nextUpdate              Time OPTIONAL,
        revokedCertificates     SEQUENCE OF SEQUENCE  {
             userCertificate         CertificateSerialNumber,
             revocationDate          Time,
             crlEntryExtensions      Extensions OPTIONAL
                                      -- if present, version MUST be v2
                                  }  OPTIONAL,
        crlExtensions           [0]  EXPLICIT Extensions OPTIONAL
                                      -- if present, version MUST be v2
                                  }

Which issue(s) this PR fixes:

Fixes #7391

Release Notes: No

@rudrakhp rudrakhp requested a review from a team as a code owner November 3, 2025 17:52
@arkodg arkodg added this to the v1.6.0 Milestone milestone Nov 3, 2025
@arkodg arkodg requested review from a team November 3, 2025 17:54
@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.33%. Comparing base (3ac9120) to head (63d590f).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7422      +/-   ##
==========================================
+ Coverage   72.31%   72.33%   +0.01%     
==========================================
  Files         231      231              
  Lines       33970    33970              
==========================================
+ Hits        24566    24572       +6     
+ Misses       7634     7629       -5     
+ Partials     1770     1769       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zirain zirain force-pushed the update_time_optional branch from 52a403a to 63d590f Compare November 4, 2025 01:29
@zirain zirain enabled auto-merge (squash) November 4, 2025 01:29
@rudrakhp
Copy link
Member Author

rudrakhp commented Nov 4, 2025

/retest

@arkodg arkodg disabled auto-merge November 4, 2025 04:41
@arkodg arkodg merged commit 669abd1 into envoyproxy:main Nov 4, 2025
51 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crl: nextUpdate and thisUpdate are optional

3 participants