Skip to content

Conversation

@zirain
Copy link
Member

@zirain zirain commented Dec 24, 2025

follow up: #7711

@zirain zirain requested a review from a team as a code owner December 24, 2025 03:00
Signed-off-by: zirain <[email protected]>
@codecov
Copy link

codecov bot commented Dec 24, 2025

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.60%. Comparing base (3ddf193) to head (42cd963).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/xds/translator/translator.go 25.00% 1 Missing and 2 partials ⚠️

❌ Your patch check has failed because the patch coverage (25.00%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7807      +/-   ##
==========================================
- Coverage   72.64%   72.60%   -0.04%     
==========================================
  Files         235      235              
  Lines       34873    34876       +3     
==========================================
- Hits        25334    25323      -11     
- Misses       7736     7746      +10     
- Partials     1803     1807       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jukie
jukie previously approved these changes Dec 24, 2025
if maxDirectResponseBodySize > DefaultCRDMaxSize {
xdsRouteCfg.MaxDirectResponseBodySizeBytes = wrapperspb.UInt32(maxDirectResponseBodySize)
}
xdsRouteCfg.MaxDirectResponseBodySizeBytes = wrapperspb.UInt32(DefaultCRDMaxSize)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we setting xdsRouteCfg.MaxDirectResponseBodySizeBytes twice if maxDirectResponseBodySize > DefaultCRDMaxSize? Is this intentional or is there a missing else?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Agreed that this should probably use a conditional instead or move line 677 above the check

Signed-off-by: zirain <[email protected]>
@zirain
Copy link
Member Author

zirain commented Dec 25, 2025

/retest

@zirain zirain requested a review from jukie December 25, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants