-
Notifications
You must be signed in to change notification settings - Fork 619
chore: use 1MB as MaxDirectResponseBodySizeBytes #7807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (25.00%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #7807 +/- ##
==========================================
- Coverage 72.64% 72.60% -0.04%
==========================================
Files 235 235
Lines 34873 34876 +3
==========================================
- Hits 25334 25323 -11
- Misses 7736 7746 +10
- Partials 1803 1807 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| if maxDirectResponseBodySize > DefaultCRDMaxSize { | ||
| xdsRouteCfg.MaxDirectResponseBodySizeBytes = wrapperspb.UInt32(maxDirectResponseBodySize) | ||
| } | ||
| xdsRouteCfg.MaxDirectResponseBodySizeBytes = wrapperspb.UInt32(DefaultCRDMaxSize) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we setting xdsRouteCfg.MaxDirectResponseBodySizeBytes twice if maxDirectResponseBodySize > DefaultCRDMaxSize? Is this intentional or is there a missing else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Agreed that this should probably use a conditional instead or move line 677 above the check
Signed-off-by: zirain <[email protected]>
|
/retest |
follow up: #7711