Skip to content

Conversation

@zhaohuabing
Copy link
Member

@zhaohuabing zhaohuabing commented Dec 24, 2025

What type of PR is this?
This PR adjusts the Envoy Gateway benchmark to measure data plane CPU performance using RPS instead of route count.

While route count is useful for evaluating the CPU performance patterns of the control plane(EG) , data plane(Envoy) CPU usage is primarily driven by request processing. Scaling load by RPS provides a more stable signal, and makes the results easier to interpret for data plane performance analysis.

It also fixes a bug in the current sampling logic where the sample data is set to 0 when failed to query Prometheus, now the failed sampling data is not considered when calculating the min/max/men in the report.

The current bechmark report:
Screenshot 2025-12-24 at 14 44 23

@zhaohuabing zhaohuabing requested a review from a team as a code owner December 24, 2025 05:19
@zhaohuabing zhaohuabing marked this pull request as draft December 24, 2025 05:19
@zhaohuabing zhaohuabing changed the title Scale up RPS to test data plane CPU performance bechmark: scale up RPS to test data plane CPU performance Dec 24, 2025
@codecov
Copy link

codecov bot commented Dec 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.63%. Comparing base (a26fba5) to head (ad6959e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7810      +/-   ##
==========================================
- Coverage   72.63%   72.63%   -0.01%     
==========================================
  Files         235      235              
  Lines       34873    34873              
==========================================
- Hits        25330    25329       -1     
- Misses       7739     7740       +1     
  Partials     1804     1804              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zhaohuabing zhaohuabing force-pushed the bechmark-scale-rps branch 5 times, most recently from 53ec2bb to e7a54d8 Compare December 24, 2025 13:49
@zhaohuabing zhaohuabing force-pushed the bechmark-scale-rps branch 3 times, most recently from 9ee7ea9 to 621f8ed Compare December 25, 2025 01:24
Signed-off-by: Huabing Zhao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant