fix: http3 duplicate matcher #7812
Open
+447
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tete17
force-pushed
the
fix/http3-duplicate-matcher-5660
branch
from
57cd2a8 to
5d4fe2e
Compare
Previously, the addServerNamesMatch function skipped adding ServerNames to FilterChainMatch for UDP/QUIC listeners entirely. This caused "duplicate matcher" errors when multiple HTTPS listeners with different hostnames shared the same address:port with HTTP/3 enabled. Fixes: envoyproxy#5660 Signed-off-by: Miguel Sacristán <[email protected]>
Add test case for HTTP/3 with multiple HTTPS listeners on the same port with different hostnames. Signed-off-by: Miguel Sacristán <[email protected]>
tete17
force-pushed
the
fix/http3-duplicate-matcher-5660
branch
from
5d4fe2e to
32b1e4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
When multiple HTTPS listeners with different hostnames share the same address:port and HTTP/3 is enabled, Envoy rejects the configuration with "duplicate matcher" errors.
This PR adds ServerNames to FilterChainMatch for QUIC listeners.
What this PR does / why we need it:
It is impossible to enable http3 on a cluster with mulitple domains witouth this.
Which issue(s) this PR fixes:
Fixes #5660