Skip to content

fix/feat: Add retry to WASM downloads - #8299

Draft
jukie wants to merge 12 commits into
envoyproxy:mainfrom
jukie:wasm-retry-policy
Draft

fix/feat: Add retry to WASM downloads#8299
jukie wants to merge 12 commits into
envoyproxy:mainfrom
jukie:wasm-retry-policy

Conversation

@jukie

@jukie jukie commented Feb 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What type of PR is this?

What this PR does / why we need it:
Mostly for flaky e2e but this is also a reasonable feature to include in real environments.

Which issue(s) this PR fixes:

Fixes #8324
Fixes #5619

Release Notes: Yes

@netlify

netlify Bot commented Feb 18, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for cerulean-figolla-1f9435 ready!

Name Link
🔨 Latest commit d6bd02a
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/6a4fbb4677c9890008c79903
😎 Deploy Preview https://deploy-preview-8299--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Feb 18, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 62.50000% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.33%. Comparing base (69e072f) to head (d6bd02a).

Files with missing lines Patch % Lines
internal/gatewayapi/envoyextensionpolicy.go 0.00% 11 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8299      +/-   ##
==========================================
- Coverage   75.34%   75.33%   -0.02%     
==========================================
  Files         252      252              
  Lines       41492    41523      +31     
==========================================
+ Hits        31263    31282      +19     
- Misses       8116     8126      +10     
- Partials     2113     2115       +2

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jukie jukie closed this Feb 28, 2026
@jukie jukie reopened this Mar 7, 2026
@jukie
jukie force-pushed the wasm-retry-policy branch from 50275a9 to 71f35bd Compare March 7, 2026 22:16
@jukie
jukie marked this pull request as ready for review March 7, 2026 22:17
@jukie
jukie requested a review from a team as a code owner March 7, 2026 22:17
@jukie jukie changed the title Add retry to WASM downloads fix/feat: Add retry to WASM downloads Mar 7, 2026
@jukie
jukie requested review from zhaohuabing and zirain March 7, 2026 22:37
zirain
zirain reviewed Mar 8, 2026
View reviewed changes
Comment thread api/v1alpha1/wasm_types.go Outdated
@jukie
jukie requested review from a team and zirain March 8, 2026 06:37
zhaohuabing
zhaohuabing reviewed Mar 9, 2026
View reviewed changes
Comment thread api/v1alpha1/wasm_types.go
zhaohuabing
zhaohuabing reviewed Mar 9, 2026
View reviewed changes
Comment thread internal/xds/translator/wasm.go
jukie and others added 4 commits March 9, 2026 07:56
@jukie
Add retry to WASM downloads
8e1c6cf 
Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
@jukie
add config
ad7e834 
Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
@jukie
description
c421a4d 
Signed-off-by: jukie <isaac.wilson514@gmail.com>
@jukie
Switch to BackOffPolicy and add CEL validation
bbf3d40 
Signed-off-by: jukie <isaac.wilson514@gmail.com>
@jukie
jukie force-pushed the wasm-retry-policy branch from 6e9c3b7 to bbf3d40 Compare March 9, 2026 13:56
@jukie
Add release note
82e1023 
Signed-off-by: jukie <isaac.wilson514@gmail.com>
@jukie
jukie requested a review from zhaohuabing March 9, 2026 13:59
@jukie
lint
b21878b 
Signed-off-by: jukie <isaac.wilson514@gmail.com>
@jukie

jukie commented Mar 9, 2026

Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@jukie

jukie commented Mar 9, 2026

Copy link
Copy Markdown
Contributor Author

/retest

zhaohuabing
zhaohuabing reviewed Mar 10, 2026
View reviewed changes
Comment thread api/v1alpha1/wasm_types.go
jukie added 2 commits March 11, 2026 07:25
@jukie
Adjust defaults and comment
ba3818e 
Signed-off-by: jukie <isaac.wilson514@gmail.com>
@jukie
Merge branch 'main' into wasm-retry-policy
86ec95c 
Signed-off-by: Isaac Wilson <isaac.wilson514@gmail.com>
@jukie
jukie requested a review from zhaohuabing March 11, 2026 13:25
@jukie
Merge branch 'main' into wasm-retry-policy
318e550 
Signed-off-by: Isaac Wilson <isaac.wilson514@gmail.com>
@jukie
jukie requested a review from a team March 13, 2026 13:55
arkodg
arkodg reviewed Mar 14, 2026
View reviewed changes
Comment thread api/v1alpha1/wasm_types.go
// +optional
PullPolicy *ImagePullPolicy `json:"pullPolicy,omitempty"`

// FetchRetryPolicy is the retry policy for Envoy to fetch the Wasm code.

@arkodg arkodg Mar 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be represented as BackendSettings inside HTTP similar to what is done in other places ?

@github-actions

github-actions Bot commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

@github-actions github-actions Bot added the stale label Apr 14, 2026
@jukie
Merge branch 'main' into wasm-retry-policy
673af34 
Signed-off-by: Isaac Wilson <isaac.wilson514@gmail.com>
@github-actions github-actions Bot removed the stale label Apr 14, 2026
@github-actions

github-actions Bot commented May 14, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

@github-actions github-actions Bot added stale and removed stale labels May 14, 2026
@github-actions

github-actions Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

@github-actions github-actions Bot added the stale label Jun 13, 2026
@github-actions github-actions Bot closed this Jun 20, 2026
@jukie jukie mentioned this pull request Jul 8, 2026
Open
@jukie jukie reopened this Jul 8, 2026
@jukie
Merge branch 'main' into wasm-retry-policy
6e469d9 
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
@jukie
jukie marked this pull request as draft July 8, 2026 15:10
@jukie jukie removed the stale label Jul 8, 2026
@zhaohuabing zhaohuabing added this to the v1.9.0-rc.1 Release milestone Jul 9, 2026
@jukie jukie mentioned this pull request Jul 9, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkodg arkodg arkodg left review comments
@zirain zirain Awaiting requested review from zirain
@zhaohuabing zhaohuabing Awaiting requested review from zhaohuabing

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.9.0-rc.1 Release

Development

Successfully merging this pull request may close these issues.

Temporary WASM HTTP failures in EnvoyExtensionPolicy do not get reconciled automatically TestE2E/WasmHTTPCodeSource is flaky

4 participants

@jukie @zhaohuabing @zirain @arkodg