Skip to content

chore: run Hook before deleting resource - #9800

Draft
zirain wants to merge 10 commits into
envoyproxy:mainfrom
zirain:fix-hook
Draft

chore: run Hook before deleting resource#9800
zirain wants to merge 10 commits into
envoyproxy:mainfrom
zirain:fix-hook

Conversation

@zirain

@zirain zirain commented Aug 19, 2026

Copy link
Copy Markdown
Member
  1. Hook should run before deleting resources fix: Hook should run before deleting resources kubernetes-sigs/gateway-api#5185
  2. Dump from the namespaces where the Gateways are
  3. clean up
  4. fix FailFast fix: FailFast not working as expected kubernetes-sigs/gateway-api#5189

@netlify

netlify Bot commented Aug 19, 2026

Copy link
Copy Markdown

Deploy Preview for cerulean-figolla-1f9435 ready!

Name Link
🔨 Latest commit 699982a
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/6a97c387ce76b50008252298
😎 Deploy Preview https://deploy-preview-9800--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.28%. Comparing base (20a3355) to head (699982a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/troubleshoot/collect.go 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9800      +/-   ##
==========================================
- Coverage   81.29%   81.28%   -0.02%     
==========================================
  Files         263      263              
  Lines       40870    40869       -1     
==========================================
- Hits        33226    33220       -6     
- Misses       7644     7649       +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread test/go.mod Outdated

replace github.com/envoyproxy/gateway => ../

replace sigs.k8s.io/gateway-api/conformance => github.com/zirain-dev/gateway-api/conformance v0.0.0-20260819115934-3b81ba94176b

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zirain
zirain force-pushed the fix-hook branch 4 times, most recently from 4638d6f to a4797c9 Compare September 2, 2026 00:55
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant