Skip to content

fix: flaky HTTPRouteMixedProtocols e2e test - #9917

Merged
zirain merged 1 commit into
envoyproxy:mainfrom
zirain:fix-mixed-protocols
Sep 2, 2026
Merged

fix: flaky HTTPRouteMixedProtocols e2e test#9917
zirain merged 1 commit into
envoyproxy:mainfrom
zirain:fix-mixed-protocols

Conversation

@zirain

@zirain zirain commented Sep 1, 2026

Copy link
Copy Markdown
Member

Signed-off-by: zirain <zirain2009@gmail.com>
@netlify

netlify Bot commented Sep 1, 2026

Copy link
Copy Markdown

Deploy Preview for cerulean-figolla-1f9435 ready!

Name Link
🔨 Latest commit 46baabb
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/6a96c0515e7f710008119142
😎 Deploy Preview https://deploy-preview-9917--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@zirain

zirain commented Sep 1, 2026

Copy link
Copy Markdown
Member Author

cc @kkk777-7

@zirain zirain changed the title fix: flaky HTTPRouteMixedProtocols e2e test- #9680 fix: flaky HTTPRouteMixedProtocols e2e test Sep 1, 2026
@codecov

codecov Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.29%. Comparing base (0008ac8) to head (46baabb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9917      +/-   ##
==========================================
- Coverage   81.29%   81.29%   -0.01%     
==========================================
  Files         263      263              
  Lines       40870    40870              
==========================================
- Hits        33227    33225       -2     
- Misses       7643     7645       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kkk777-7

kkk777-7 commented Sep 1, 2026

Copy link
Copy Markdown
Member

LGTM, thanks!

@kkk777-7

kkk777-7 commented Sep 1, 2026

Copy link
Copy Markdown
Member

I understood that why our e2e tests become flaky recently.

Date Change Effect
2026-03-06 #8388 added TimeoutConfig() with RequiredConsecutiveSuccesses = 0 Worked as intended — conformance was on v1.5.x, which had no default for this field
2026-07-13 kubernetes-sigs/gateway-api#5036 added the missing timeout defaults, including RequiredConsecutiveSuccesses (cherry-picked to release-1.6 in kubernetes-sigs/gateway-api#5066) 0 now gets replaced by the default 3
2026-07-17 #9515 bumped Gateway API to v1.6.1 The setting from #8388 was silently reverted suite-wide
2026-08-03 #9647 filed: HTTPRouteMixedProtocols is flaky First report, 17 days after the bump

@zirain
zirain marked this pull request as ready for review September 1, 2026 12:36
@zirain
zirain requested a review from a team as a code owner September 1, 2026 12:36
@zirain

zirain commented Sep 1, 2026

Copy link
Copy Markdown
Member Author

I understood that why our e2e tests become flaky recently.

Date Change Effect
2026-03-06 #8388 added TimeoutConfig() with RequiredConsecutiveSuccesses = 0 Worked as intended — conformance was on v1.5.x, which had no default for this field
2026-07-13 kubernetes-sigs/gateway-api#5036 added the missing timeout defaults, including RequiredConsecutiveSuccesses (cherry-picked to release-1.6 in kubernetes-sigs/gateway-api#5066) 0 now gets replaced by the default 3
2026-07-17 #9515 bumped Gateway API to v1.6.1 The setting from #8388 was silently reverted suite-wide
2026-08-03 #9647 filed: HTTPRouteMixedProtocols is flaky First report, 17 days after the bump

there're various bug in release-1.6, see #9802

and kubernetes-sigs/gateway-api#5185 is pending for review.

@zirain
zirain merged commit 984c679 into envoyproxy:main Sep 2, 2026
90 of 97 checks passed
@zirain
zirain deleted the fix-mixed-protocols branch September 2, 2026 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix mixed backend test

2 participants