Preserve changelogs/current/PLACEHOLDER.txt in entries-layout changelog writes#4643
Draft
Copilot wants to merge 2 commits into
Draft
Preserve changelogs/current/PLACEHOLDER.txt in entries-layout changelog writes#4643Copilot wants to merge 2 commits into
changelogs/current/PLACEHOLDER.txt in entries-layout changelog writes#4643Copilot wants to merge 2 commits into
Conversation
✅ Deploy Preview for nifty-bassi-e26446 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix write_version method to preserve PLACEHOLDER.txt
Preserve Jun 11, 2026
changelogs/current/PLACEHOLDER.txt in entries-layout changelog writes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AChangelogs.write_version()andwrite_current()in entries-layout mode could leavechangelogs/current/empty after writing a release/dev changelog. That removedcurrent/PLACEHOLDER.txt, which Envoy’s changelog filegroup expects, and caused downstream workflow failures.Root cause addressed
changelogs/current/but did not restore the tracked placeholder file.Code changes
CHANGELOG_CURRENT_PLACEHOLDER = "PLACEHOLDER.txt"in the changelog constants.AChangelogs.current_placeholder_path:self.current_dir_path.joinpath(CHANGELOG_CURRENT_PLACEHOLDER).write_current()to ensure directory + placeholder:mkdir(..., exist_ok=True)thencurrent_placeholder_path.touch().write_version()to restore placeholder after clearing/recreatingcurrent/:shutil.rmtree(...),mkdir(), thencurrent_placeholder_path.touch().Test updates
current_placeholder_path.write_current/write_versiontests to asserttouch()behavior on entries-layout vs legacy paths.write_versionstate contains exactly one file: emptyPLACEHOLDER.txt.