Use modern postSetParametersCallback - #5
Merged
Conversation
Also solves the bug causing every Double parameters change in the entire system to be printed as a change in this node
adivardi
changed the title
sharminramli
requested changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additions & Changes
Use modern postSetParametersCallback
Also solves the bug causing every Double parameters change in the entire system to be printed as a change in this node
How to test & expected outcomes
Previously, changing a param of ANY node would cause all 3 imu_filter_madwick nodes to print a change notice.
With this change it should not happen.
Play a bit with the param and check they are actually modified (e.g.
orientation_stddevaffects/sensors/inertial/right/imu_orientationPR in upstream: CCNYRoboticsLab#220