Skip to content

issue #591: move herddb.index.vector storage classes to herddb-indexing-service - #593

Merged
eolivelli merged 1 commit into
masterfrom
issue-591-move-herddb-index-vector-storage-classes
May 19, 2026
Merged

eolivelli merged 1 commit into
masterfrom
issue-591-move-herddb-index-vector-storage-classes

Conversation

@eolivelli

Copy link
Copy Markdown
Owner

Fixes #591.

Changes

herddb-core — classes removed

  • Deleted 18 production classes (AbstractVectorStore, PersistentVectorStore, ReadOnlyVectorStore, VectorIndexCompactor, VectorSegment, NewSegmentInfo, PagedPkSet, CompactionAuthorityMap, SegmentPublisher, GraphWriterFactory, RemoteSegmentGraphMerger, VectorMemoryBudget, VectorStorage, VectorStorageRandomAccessVectorValues, ChannelFileBackedVectorValues, FileBackedVectorValues, MmapFileBackedVectorValues, SegmentedMappedReader) from herddb.index.vector
  • Kept in herddb-core: VectorIndexManager (instantiated by TableSpaceManager), RemoteVectorIndexService (SPI interface used by DBManager), and PinModeReaderSupplier (used by herddb-remote-file-service which cannot depend on herddb-indexing-service)
  • Deleted 58 companion unit tests; moved to herddb-indexing-service

herddb-indexing-service — classes added

  • Added new package herddb.indexing.vector with the 18 moved production classes (package rename from herddb.index.vector → herddb.indexing.vector)
  • Added 58 unit tests under src/test/java/herddb/indexing/vector/
  • Added io.github.jbellis:jvector as a direct dependency (pom.xml)
  • Updated all import statements in existing consumers (IndexingServiceEngine, VectorIndexRebuilder, InMemoryVectorStore, VectorStoreFactory, optimizer/*, segment/*, and all test classes)

herddb-remote-file-service — import updated

  • RemoteRandomAccessReader + RemoteRandomAccessReaderPinModeTest: updated import herddb.index.vector.PinModeReaderSupplier to use explicit package (class stays in herddb-core but was previously accessed via same-package from a file now in a different package)

Tests

  • Pre-PR validation (Spotless + Apache RAT + SpotBugs + install -DskipTests -Pci) passed for all 22 modules
  • Targeted test runs green: VectorIndexRetentionTest, PersistentVectorStoreCapComputationTest, PersistentVectorStoreBackoffTest, PersistentVectorStoreSupportsVectorIndexesTest, VectorIndexCompactorChooseTest, CompactionAuthorityMapBLinkTest (in herddb-indexing-service)
  • VectorIndexManager tests remain green in herddb-core: VectorIndexManagerRebuildLsnCodecTest, VectorIndexManagerDropNotifiesRemoteServiceTest, VectorIndexManagerSearchStreamTest

🤖 Implemented by the pr-worker agent.

…ng-service

Move 18 production classes (AbstractVectorStore, PersistentVectorStore,
ReadOnlyVectorStore, VectorIndexCompactor, VectorSegment, NewSegmentInfo,
PagedPkSet, CompactionAuthorityMap, SegmentPublisher, GraphWriterFactory,
RemoteSegmentGraphMerger, VectorMemoryBudget, VectorStorage,
VectorStorageRandomAccessVectorValues, ChannelFileBackedVectorValues,
FileBackedVectorValues, MmapFileBackedVectorValues, SegmentedMappedReader)
from herddb-core to herddb-indexing-service under the new package
herddb.indexing.vector.

Move 58 companion test files from herddb-core to herddb-indexing-service.
Keep VectorIndexManager, RemoteVectorIndexService, and PinModeReaderSupplier
in herddb-core (used by TableSpaceManager, DBManager, and
RemoteRandomAccessReader respectively).

Add io.github.jbellis:jvector as a direct dependency of
herddb-indexing-service. Fix PinModeReaderSupplier import in
herddb-remote-file-service (class stays in herddb-core but its
formerly same-package test reference needs an explicit import in
herddb-indexing-service).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@eolivelli
eolivelli merged commit b2a590e into master May 19, 2026
8 checks passed
@eolivelli
eolivelli deleted the issue-591-move-herddb-index-vector-storage-classes branch May 19, 2026 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move herddb.index.vector storage classes from herddb-core to herddb-indexing-service

1 participant