fix: Add missing file_id parameter to BuiltinKnowledgeGraph.aload_doc… #2926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ument() In v0.7.0, the file_id parameter was added to the knowledge graph loading pipeline to support document-level graph structure tracking. However, the BuiltinKnowledgeGraph.aload_document() method was not updated accordingly. This commit adds the file_id parameter to match the interface used by: - IndexStoreBase.aload_document_with_limit() (caller) - VectorStoreBase.aload_document() (correct implementation) - CommunitySummaryKnowledgeGraph.aload_document() (correct implementation) Changes: - Added file_id: Optional[str] = None parameter to the method signature - Updated docstring to document the new parameter - Maintained the # type: ignore comment for base class signature compatibility
Aries-ckt
approved these changes
Nov 3, 2025
Collaborator
Aries-ckt
left a comment
Aries-ckt
left a comment
There was a problem hiding this comment.
LGTM.thanks for your contribution.
chenliang15405
approved these changes
Nov 4, 2025
Collaborator
chenliang15405
left a comment
chenliang15405
left a comment
There was a problem hiding this comment.
LGTM, Thanks for your contribution
15 tasks
lusains
deleted the
claude/add-file-id-builtin-kg-011CUkhwWzKkBunzk4t5NQJi
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ument()
In v0.7.0, the file_id parameter was added to the knowledge graph loading pipeline to support document-level graph structure tracking. However, the BuiltinKnowledgeGraph.aload_document() method was not updated accordingly.
This commit adds the file_id parameter to match the interface used by:
Changes:
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Snapshots:
Include snapshots for easier review.
Checklist: