TaskList. Anastasiya Santalova #2
Conversation
…d saving tasks after reloading
…e functional and visual parts.
Anastasiya Santalova/app.js
Outdated
| var taskList; | ||
| var localTaskList = JSON.parse(localStorage.getItem('myArr')); | ||
|
|
||
| if (localTaskList.length == 0) { |
There was a problem hiding this comment.
It would fail while getting length if I don't have such item in local storage.
Also, use triple equals operator
Anastasiya Santalova/app.js
Outdated
| break; | ||
| case 'today': | ||
| taskList.forEach(function (curr) { | ||
| console.log(compareDates(curr.deadline)); |
Anastasiya Santalova/app.js
Outdated
| // * CHANGESTAT: change and save task status (completed / not completed) | ||
|
|
||
|
|
||
| var list = (function (){ |
There was a problem hiding this comment.
Please add whitespace before curly brace
In future I'd recommend to use linters e.g. ESLint which have warning messages if you violate the styleguide and also some tools like Prettier which could fix those problems
Anastasiya Santalova/app.js
Outdated
| } | ||
|
|
||
| return { | ||
| create: function (text,deadline) { |
Anastasiya Santalova/app.js
Outdated
| var ind; | ||
|
|
||
| taskList.forEach(function (curr, i) { | ||
| if (curr.id == id) { |
Anastasiya Santalova/SCSS/app.scss
Outdated
|
|
||
| border-bottom: 1px dashed lightgray; | ||
|
|
||
| //@include borderGray(dashed); |
Anastasiya Santalova/app.js
Outdated
| delete: function (id) { | ||
| var ind; | ||
|
|
||
| taskList.forEach(function (curr, i) { |
There was a problem hiding this comment.
Instead of forEach + splice combination I'd use filter
Anastasiya Santalova/app.js
Outdated
| div.appendChild(delSpan); | ||
| delSpan.appendChild(delButton); | ||
|
|
||
| delButtonOnclick(); |
There was a problem hiding this comment.
Use camelCase please: delButtonOnClick. The same note for the function below
Anastasiya Santalova/app.js
Outdated
| }, | ||
|
|
||
| changestat: function(id) { | ||
| taskList.forEach(function (curr) { |
There was a problem hiding this comment.
I'd use find since it will stop after finding needed element
There was a problem hiding this comment.
As far as I know find can be used only in ES6
Anastasiya Santalova/app.js
Outdated
| list.push(newTask); | ||
| list.show(); | ||
| } | ||
| };; |
No description provided.