ToDo list app #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bye
reviewed
Aug 21, 2019
Roslyakov Evgeny/index.html
Outdated
| </header> | ||
| <section class="todo-list"> | ||
| <div class="tasks-container"> | ||
| <!--<section class="task task-checked" id="idx-%ID%"> |
There was a problem hiding this comment.
of course not, this is just for developing purposes
| id = (allTasks.length) ? allTasks[allTasks.length - 1].id + 1 : 0; | ||
|
|
||
| // create the task date | ||
| var thisMonth = months[(new Date()).getMonth()]; |
There was a problem hiding this comment.
normally we don't use 'this' in naming, not forbidden, just could be strange
There was a problem hiding this comment.
I thought that reserved words are not forbidden as parts of consistent names. I will be careful
Roslyakov Evgeny/main.js
Outdated
|
|
||
| // sort by deadline | ||
| sortByDeadline: function (deadline) { | ||
| var sortedArr = allTasks.filter(function (task) { |
There was a problem hiding this comment.
It looks more like filtering, not sorting. Please be careful with naming.
Roslyakov Evgeny/main.js
Outdated
|
|
||
| // sort by done / undone | ||
| sortByDone: function (done) { | ||
| var sortedArr = allTasks.filter(function (task) { |
There was a problem hiding this comment.
I will rename those functions
Roslyakov Evgeny/main.js
Outdated
| deleteButton: 'task-delete', | ||
| checkButton: 'task-check', | ||
| tasksContainer: '.tasks-container', | ||
| sortDayBtn: '.sort-tomorrow', |
Roslyakov Evgeny/index.html
Outdated
| <span>deadline:</span> | ||
| <ul class="radio-wrapper"> | ||
| <li> | ||
| <label><input type="radio" class="new-task__deadline" name="set-deadline" value="none">none</label> |
There was a problem hiding this comment.
I so that this value is set as default in js part, what do you think about putting here checked attribute to show the user that it is a default?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.