Skip to content

chore(auth): use FastAPI's HTTPBearer for JWT token extraction #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Roman505050 wants to merge 1 commit into
base: development
Choose a base branch
from
Open

chore(auth): use FastAPI's HTTPBearer for JWT token extraction #240

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion aidial_sdk/deployment/from_request_mixin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from urllib.parse import urljoin

import fastapi
from fastapi.security import HTTPBearer

from aidial_sdk.exceptions import InternalServerError, InvalidRequestError
from aidial_sdk.pydantic_v1 import Field, SecretStr, StrictStr, root_validator
Expand Down Expand Up @@ -34,6 +35,7 @@ class FromRequestDeploymentMixin(FromRequestMixin):

_DIAL_APPLICATION_PROPERTIES_HEADER = "X-DIAL-APPLICATION-PROPERTIES"
_DIAL_APPLICATION_ID_HEADER = "X-DIAL-APPLICATION-ID"
_bearer = HTTPBearer(auto_error=False)

headers: Mapping[str, str]
base_url: Optional[str] = None
Expand Down Expand Up @@ -139,7 +141,8 @@ async def from_request(
raise InvalidRequestError("Api-Key header is required")
del headers["Api-Key"]

jwt = headers.get("Authorization")
auth_credentials = await cls._bearer(request)
jwt = auth_credentials.credentials if auth_credentials else None
del headers["Authorization"]

application_properties = None
Expand Down
Loading