Skip to content

#10034 System doens't assing added bonds to defined Preset component #10153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oguzhanduran wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#10034 System doens't assing added bonds to defined Preset component #10153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ketcher-react/src/script/editor/Editor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2101,7 +2101,7 @@ class Editor implements KetcherEditor {

const rnaComponentToAssign = beginAtomRnaComponent ?? endAtomRnaComponent;
const struct = this.struct();
const atomIdToStartFrom = beginAtomRnaComponent ? bond.begin : bond.end;
const atomIdToStartFrom = beginAtomRnaComponent ? bond.end : bond.begin;
Copy link
Copy Markdown
Contributor

@claude claude Bot Jun 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix is correct — the previous code seeded the traversal from the atom already assigned to the component, so it walked through component atoms first and could incorrectly trip hasConnectionToOriginalStructure for connections that have nothing to do with the new bond. Two suggestions while this line is being touched:

  1. Rename atomIdToStartFrom → unassignedAtomId (or similar). The intent — "start from the unassigned endpoint" — would then be self-documenting, and the ternary's direction obvious by inspection. This is exactly the kind of bug that name-driven clarity prevents from regressing.
  2. Consider adding a focused unit test for this function. The three branches (no component / one component / two components) plus the "unassigned side reaches the original structure" case are highly testable, and a regression test would lock in this silent semantic inversion.

const visitedAtomIds = new Set<number>();
const atomsToCheck = [atomIdToStartFrom];
let hasConnectionToAnotherComponent = false;
Expand Down
Loading