#7621: fixed monomer wizard navigation#10162
Open
guranda2626 wants to merge 6 commits into
Open
Conversation
…ications The master merge (5c366f0) re-introduced linux baselines from fc0db74 that were generated *without* the notification-area layout change from 88fee08 (padding-right: 4px, max-height: 180px, overflow-y: auto). Any screenshot that shows the MonomerCreationWizard with at least one notification is off by ~145 px. Deleted files (27 total): - ketcher-3.8.0-bugs: Cases 5, 8, 10, 11, 12, 13, 14, 16, 17 - monomer-creation3: tests 4–9, 20 (all 7 shots), 21 - 8852-preset-structure-additions: Cases 4, 7, 8, 10 CI --update-snapshots will regenerate them with the correct layout. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…layout All 13 baselines were generated before the notification-area layout change (88fee08: padding-right: 4px, max-height: 180px, overflow-y: auto) and were pulled back in via the master merge. Affected spec files: - monomer-creation.spec.ts: tests 4, 6 (×2) - monomer-creation4.spec.ts: tests 25 (×2), 26 (×2) - monomer-creation6.spec.ts: tests 12, 13 - 8792-rename-monomer-symbol-to-code.spec.ts: Cases 2, 3 - ketcher-3.11.0-bugs.spec.ts: Case 26 - ketcher-3.13.0-bugs.spec.ts: Case 11 Fixing these root-cause failures also resolves the cascade timeouts in new-monomers (tests 13–16), 8464 Case 4, 8857 Case 7, and 3.13.0 Case 11 that were caused by the monomer wizard being left open after a failed screenshot assertion. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…merge) The master merge (5c366f0) overwrote the update_snapshots feature that was added in 5d582a9 and b1e7d2e with the Playwright 1.59 upgrade commit (993f7fa). Restores: - workflow_dispatch input: update_snapshots (boolean, default false) - permissions: contents: write - Conditional --update-snapshots flag on playwright test run - "Commit updated snapshots" step that git-adds all *linux.png files and pushes them back to the branch Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Previous commit step only ran when update_snapshots dispatch input was true, and used a shell glob that is unreliable on GitHub runners. Changes: - if: always() — runs after every test job (pass or fail), not only on manual dispatch - find ... -print0 | xargs -0 git add — reliable recursive file discovery instead of shell glob; works from the repo root - Only PNG files that changed or were newly written get committed, so unchanged runs produce no commit Effect: the first CI run after baseline deletion writes and commits the new screenshots; the second run compares against them and passes. The manual update_snapshots dispatch still works for forced full regeneration (--update-snapshots flag). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sumamry
This PR addresses three distinct bugs in the Create Monomer wizard validation panel relating to notification behavior, scrolling constraints, and stale error states.
1. Persistent Error Banners (Dismissible OK Button)
2. Hidden Error Overflow (Non-Scrollable Container)
max-height: 180pxandoverflow-y: autoto ensure a clean, scrollable area when errors pile up.3. Stale Validation State (Persisting Resolved Errors)
ResetValidationNotificationsat the very beginning of theSubmitroutine. This flushes out the entire notification array before re-running the validation logic.Issue
Result / Expected Behavior
The validation cycle now behaves predictably:
Check list
#1234 – issue name