Skip to content

#7775 - Inconsistent selection highlight colors between Rectangle and Lasso tools compared to Micro mode - #11908

Open
mariam-khutuashvili wants to merge 2 commits into
masterfrom
7775-inconsistent-selection-highlight-colors-between-rectangle-and-lasso-tools-compared-to-micro-mode
Open

mariam-khutuashvili wants to merge 2 commits into
masterfrom
7775-inconsistent-selection-highlight-colors-between-rectangle-and-lasso-tools-compared-to-micro-mode

Conversation

@mariam-khutuashvili

@mariam-khutuashvili mariam-khutuashvili commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator
ma1 ma2 mi1 mi2

The rectangle and lasso outline drawn while dragging a selection in Macromolecules mode now uses the same style as Molecules mode: a grey stroke and no fill. Previously it was #B4B9D6, and the lasso area was additionally filled with #E1E5EA at 50 %.

  • SELECTION_OUTLINE_COLOR added to renderers/constants.ts (next to the shared SELECTION_COLOR) and used by both modes: Micro's lassoStyle in options.ts (value-identical) and Macro's SelectionView.
  • The lasso is now a single closed path (d3.curveLinearClosed) with no fill, so the separate closing-line element and the fill-opacity are gone.
  • Stroke width is deliberately left as is: Macro's outline lives under the zoom transform and scales with zoom, which is unrelated to this issue.
  • Unit test added for SelectionView (rectangle attributes, lasso is one closed unfilled path).

Verified in the browser mid-drag for both tools against Molecules mode. No autotest screenshots capture a selection mid-drag, so no baselines change; CI here demonstrates no regression rather than proving the fix.

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent selection highlight colors between Rectangle and Lasso tools compared to Micro mode

1 participant