#11900 - rewrite packagesketcher coresrcdomainserializersmolutilsjs from javascript to typescript - #11910
Open
armankarapetyan-svg wants to merge 2 commits into
Conversation
…s-from-javascript-to-typescript
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
(Screenshots, videos, or GIFs, if applicable)
Converted packages/ketcher-core/src/domain/serializers/mol/utils.js from JavaScript to TypeScript with comprehensive type definitions, eliminating all implicit any types.
Changes
File Migration: Converted utils.js to utils.ts with full TypeScript support
Type Definitions: Introduced 3 new interfaces to replace implicit types:
Enum Usage: Added FragmentType enum for clear fragment classification (Reactant, Product, Agent)
Function Signatures: All 18 utility functions now have explicit parameter and return types:
Type Safety Improvements
Breaking Changes
Testing
All type checks pass without errors
Existing imports in common.ts, molfile.ts, parseSGroup.ts, and v2000.ts verified and working
No functional changes to exported utilities
Check list
#1234 – issue name