Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
(Screenshots, videos, or GIFs, if applicable)
The fix is in place. Here's the analysis:
Root cause: In shared.ts::load, after dispatching the paste tool action (when fragment: true), two canvas-resetting operations were unconditionally called:
Both are wrong for the "Add to Canvas" case because the structure is only attached to the cursor at that point (not yet placed on canvas), so the viewport should stay exactly where the user left it.
Fix: Added !fragment guard to both calls. When fragment: true:
Side effects: This also improves Ctrl+V clipboard paste behavior (which also uses fragment: true) — zoomAccordingContent was being called there too (a bug), now it won't change the zoom when the user pastes from clipboard. centerStruct was already protected by isPaste: true for clipboard paste, so that's unchanged.
Check list
#1234 – issue name