Skip to content

#11902 rewrite packages\ketcher-core\textFileTransformer.js from JavaScript to TypeScript - #11924

Open
armankarapetyan-svg wants to merge 2 commits into
masterfrom
11902-lets-rewrite-packagesketcher-coretextfiletransformerjs-from-javascript-to-typescript
Open

armankarapetyan-svg wants to merge 2 commits into
masterfrom
11902-lets-rewrite-packagesketcher-coretextfiletransformerjs-from-javascript-to-typescript

Conversation

@armankarapetyan-svg

@armankarapetyan-svg armankarapetyan-svg commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

How the feature works? / How did you fix the issue?

(Screenshots, videos, or GIFs, if applicable)

Created textFileTransformer.ts with proper TypeScript typing:

  • Imported Transformer from @jest/transform to type the transformer object
  • Explicitly typed all parameters and return values
  • Used the Transformer interface to properly type the entire object
  • Added comprehensive JSDoc comments explaining the transformer's purpose
    Updated jest.config.js to reference the new TypeScript file (.ts instead of .js)

Removed the old textFileTransformer.js file

Verified - TypeScript compilation shows no errors ✓

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@armankarapetyan-svg armankarapetyan-svg changed the title 11902 rewrite packages\ketcher-core\textFileTransformer.js from JavaScript to TypeScript #11902 rewrite packages\ketcher-core\textFileTransformer.js from JavaScript to TypeScript Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Let's rewrite packages\ketcher-core\textFileTransformer.js from JavaScript to TypeScript

1 participant