#11078 – Paste option is enabled in Macromolecules mode when the clipboard is empty or contains not applicable content - #11925
Open
OnurKucukoz wants to merge 1 commit into
Conversation
…d content is invalid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
The Paste option in the Macromolecules canvas context menu was enabled for any non-empty clipboard text, even when the content could not be converted and pasted.
This change validates clipboard content using the existing Indigo/KET conversion path before enabling Paste. Validation is performed without modifying the canvas, updating history, or displaying an error modal.
A regression test verifies that Paste is enabled for valid HELM content and becomes disabled after the clipboard is changed to invalid plain text.
After Fix
Invalid clipboard content disables the Paste option, while valid HELM content enables Paste and can be added to the canvas.
Issue.11078.-.Manuel.verification.mp4
Testing
Manually verified empty, invalid, HELM, and SMILES clipboard content
Playwright regression test passed
npm run check:autotests
TypeScript and ESLint checks passed
git diff --check
Fixes #11078
Check list
#1234 – issue name