#9489 - Nucleotide presets: Creating preset with the same component codes replaces properties of the existing preset - #11926
Open
beyzaevcen wants to merge 1 commit into
Conversation
…overwrites an existing preset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
(Screenshots, videos, or GIFs, if applicable)
Presets with different names but identical Base/Sugar/Phosphate component
codes collided during library updates:
components' ids, not from the preset's own name, so two presets sharing
component codes could get the same $ref and overwrite each other in the
library.
areSameMonomersin Editor.ts matched hidden monomer components bysymbol/class/hidden only, ignoring
id. A later preset's component withthe same code silently overwrote an earlier preset's dictionary entry,
so the later preset's own component ref was never registered and it got
filtered out as "missing a component".
setDefaultPresetsbailed out entirely once presetsDefault already haddata, matching only against the first item's name, so newly added
presets never reached Redux state until a full reload.
Fix each of the three points so presets with shared component codes but
distinct names are stored, resolved, and rendered independently.
Check list
#1234 – issue name