#2660 Can't attach copied or cutted Functional Group to atoms of structure#2713
Draft
kaluginserg wants to merge 9 commits into
Draft
#2660 Can't attach copied or cutted Functional Group to atoms of structure#2713kaluginserg wants to merge 9 commits into
kaluginserg wants to merge 9 commits into
Conversation
gairon
reviewed
Jun 1, 2023
Collaborator
|
@copilot resolve the merge conflicts in this pull request |
Collaborator
|
@copilot resolve the merge conflicts in this pull request |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2660
What was done:
isSingleContractedGroupas it is not working as expected, finally in the current implementation it works only when we past group on group, but if we try to past Atom on group or structure on structure, or group on atom - it's not working. So the decision is to have it as is, and later fix all issues with Past tool at once with the new implmementation.filterSlatAndSolventFromMerge()in the tools folder. It's the short-term solution as in the better way it must be inside the ketcher-coreclosest.merge(the same asfindCloseMerge), and removed from the tools level.How it works now (On the video: begining from Template, then using select tool, and after that using Paste tool):
Screen.Recording.2023-06-01.at.14.03.31.mov
It is still a difference in the behavior of the tools: