Skip to content

7083 Delete operation on Sequence mode causes hanging bonds and undeletable monomers#7166

Open
KristinaKasyanovskaya wants to merge 20 commits into
masterfrom
7083-delete-operation-on-sequence-mode-causes-hanging-bonds-and-undeletable-monomers
Open

7083 Delete operation on Sequence mode causes hanging bonds and undeletable monomers#7166
KristinaKasyanovskaya wants to merge 20 commits into
masterfrom
7083-delete-operation-on-sequence-mode-causes-hanging-bonds-and-undeletable-monomers

Conversation

@KristinaKasyanovskaya
Copy link
Copy Markdown
Collaborator

How the feature works? / How did you fix the issue?

(Screenshots, videos, or GIFs, if applicable)

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@KukushkinDmi1riy KukushkinDmi1riy changed the title Draft 7083 Delete operation on Sequence mode causes hanging bonds and undeletable monomers 7083 Delete operation on Sequence mode causes hanging bonds and undeletable monomers Jul 21, 2025
@KukushkinDmi1riy KukushkinDmi1riy self-assigned this Jul 21, 2025
@KristinaKasyanovskaya KristinaKasyanovskaya marked this pull request as ready for review July 21, 2025 09:42
@AlexeyGirin
Copy link
Copy Markdown
Collaborator

@copilot resolve the merge conflicts in this pull request

@AlexeyGirin
Copy link
Copy Markdown
Collaborator

@copilot resolve the merge conflicts in this pull request

@AlexeyGirin
Copy link
Copy Markdown
Collaborator

@copilot resolve the merge conflicts in this pull request

@AlexeyGirin
Copy link
Copy Markdown
Collaborator

@copilot resolve the merge conflicts in this pull request

@AlexeyGirin
Copy link
Copy Markdown
Collaborator

@copilot resolve the merge conflicts in this pull request

Copy link
Copy Markdown
Contributor

Copilot AI commented May 31, 2026

@copilot resolve the merge conflicts in this pull request

Resolved the merge conflicts in packages/ketcher-core/src/application/editor/modes/SequenceMode.ts (commit cdb634a). The only conflicting file combined master's refactor (the monomersBeingDeleted handling, nullish-coalescing, named sensePhosphateAdditionallyDeleted/antisensePhosphateAdditionallyDeleted booleans, and the !isEditMode guard for selection deletion) with this PR's fix (the backbone delete "-" rewrite using firstConnected/secondConnected polymer-bond detection and the unified deleteHandler). The now-unused previouseNodeInBackbone variable was removed. ketcher-core typecheck and build pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants