Skip to content

#8849 Entering the wizard - presets in the monomer creation wizard#8906

Merged
rrodionov91 merged 5 commits into
masterfrom
copilot/add-presets-in-monomer-wizard
Dec 19, 2025
Merged

#8849 Entering the wizard - presets in the monomer creation wizard#8906
rrodionov91 merged 5 commits into
masterfrom
copilot/add-presets-in-monomer-wizard

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Dec 11, 2025

How the feature works? / How did you fix the issue?

The monomer creation wizard now warns users before leaving “Nucleotide (preset)” and positions that option directly below “Nucleotide (monomer)” in the type selector.

  • Dropdown ordering: MonomerTypeSelectConfig now lists “Nucleotide (preset)” immediately after “Nucleotide (monomer)” to match UX requirements.
  • Type change confirmation: Selecting a new type while on “Nucleotide (preset)” opens a modal: “Changing the type will result in a loss of inputted data. Do you wish to proceed?” with Cancel (default) and Yes.
  • Test coverage: Added a Jest unit test to guard the ordering of type options and mapped ketcher-core aliases for tests.
{showTypeChangeDialog &&
  <Dialog
    title="Confirm type change"
    buttons={['OK', 'Cancel']}
    buttonsNameMap={{ OK: 'Yes', Cancel: 'Cancel' }}
    primaryButtons={['Cancel']}
  >
    Changing the type will result in a loss of inputted data. Do you wish to proceed?
  </Dialog>}

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request
Original prompt

This section details on the original issue you should resolve

<issue_title>Entering the wizard - presets in the monomer creation wizard</issue_title>
<issue_description>## Background

This is an improvement to the previous logic contained in this ticket.

Requirements

$\color{Red}{\textbf{Entering the wizard}}$

1.1. If the user picks a different monomer type after Nucleotide (preset) was picked, they should get a warning message in a modal window: "Changing the type will result in a loss of inputted data. Do you wish to proceed?"
with options "Cancel" (default)
and "Yes" (changes the monomer type, the structure is loaded into the wizard anew)
and a title "Confirm type change".

1.2. The type Nucleotide (preset) should be placed below the type Nucleotide (monomer) in the drop-down.


$\color{Red}{\textbf{Defining the monomers}}$

$\color{Pink}{\textbf{Defining the monomer structure}}$

❗ The requirements for this section contained in a separate ticket. ❗

$\color{Pink}{\textbf{Highlighting}}$

❗ The requirements for this section contained in a separate ticket. ❗

$\color{Pink}{\textbf{Additions to the structure}}$

❗ The requirements for this section contained in a separate ticket. ❗

$\color{Pink}{\textbf{Defining other monomer properties}}$

❗ The requirements for this section contained in a separate ticket. ❗

$\color{Pink}{\textbf{Additional helpful information}}$

❗ The requirements for this section contained in a separate ticket. ❗

$\color{Pink}{\textbf{Monomer saving}}$

❗ The requirements for this section contained in a separate ticket. ❗


$\color{Red}{\textbf{Defining the preset}}$

❗ The requirements for this section contained in a separate ticket. ❗


$\color{Red}{\textbf{Preset-specific error messages}}$

❗ The requirements for this section contained in a separate ticket. ❗


$\color{Red}{\textbf{Exiting the wizard}}$

❗ The requirements for this section contained in a separate ticket. ❗


UX

Image Image Image Image Image Image Image Image Image Image Image

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Add presets functionality in monomer creation wizard Add confirmation when changing from nucleotide preset and reorder type dropdown Dec 11, 2025
Copilot AI requested a review from AlexeyGirin December 11, 2025 10:14
@AlexeyGirin AlexeyGirin added Sonar Bucket: Issues found by Sonar scanner Fixed by ChatGPT5 feature to mark feature pull requests and removed Sonar Bucket: Issues found by Sonar scanner labels Dec 15, 2025
@AlexeyGirin AlexeyGirin marked this pull request as ready for review December 15, 2025 07:54
@AlexeyGirin AlexeyGirin changed the title Add confirmation when changing from nucleotide preset and reorder type dropdown #8849 Entering the wizard - presets in the monomer creation wizard Dec 16, 2025
@rrodionov91 rrodionov91 force-pushed the copilot/add-presets-in-monomer-wizard branch from cd2e613 to 5e6cea3 Compare December 19, 2025 08:42
@rrodionov91 rrodionov91 merged commit 60511dd into master Dec 19, 2025
14 of 15 checks passed
@rrodionov91 rrodionov91 deleted the copilot/add-presets-in-monomer-wizard branch December 19, 2025 10:39
AlexeyGirin added a commit that referenced this pull request Jan 3, 2026
…8906)

* Initial plan

* Add preset type change confirmation dialog

Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com>

* - reverted unnecessery changes

* - added clearing highlights

* - fixed tests

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com>
Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Entering the wizard - presets in the monomer creation wizard

3 participants