-
Notifications
You must be signed in to change notification settings - Fork 1
feat: switch to gpt5 models #92 #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Changes from all commits
bb7b88c
8784ca4
4536223
615702a
9e98dcd
b48cf3b
3fe8ff6
b5ee249
e5f044c
a9960ad
d418829
2589a92
bbdcdc8
2531312
ac24314
eccd61c
7a565e4
bd3f8ea
6d39a70
1b431d9
0c48f10
dc235d9
5c062be
6a47f43
03f6b58
65b3233
6b47b9b
8415cdd
be1a530
dbfa009
9d2dcf0
5de1029
0e659c6
7a09009
73eb3a7
883a993
980b67c
e9fc7d5
484263b
1748758
fbc4a75
7228c92
d6fc10e
615eac1
4f12137
e4ba152
c3c9fb8
e32177e
2f1e33e
d537b40
93c0b52
95ead44
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,7 @@ | |
|
|
||
| class BaseRagState(ToolMessageState): | ||
| type: ToolTypes = ToolTypes.FILE_RAG | ||
| version: RAGVersion | ||
| version: RAGVersion = RAGVersion.DIAL | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why do we set this default? |
||
|
|
||
| response: str = "" # This is not needed since we have content field | ||
| answered_by: str = "" | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,7 @@ | |
| from pydantic import Field, PositiveInt, TypeAdapter, field_validator, model_validator | ||
| from pydantic_core.core_schema import FieldValidationInfo | ||
|
|
||
| from statgpt.common.config import LLMModelsEnum | ||
| from statgpt.common.config import LLMModelsEnum, ReasoningEffortEnum, VerbosityEnum | ||
| from statgpt.common.config.utils import replace_env | ||
|
|
||
| from .base import BaseYamlModel, SystemUserPrompt | ||
|
|
@@ -175,11 +175,21 @@ class HybridSearchConfig(BaseYamlModel): | |
|
|
||
| normalize_model_config: LLMModelConfig = Field( | ||
| description="LLM Model used for normalization", | ||
| default_factory=lambda: LLMModelConfig(deployment=LLMModelsEnum.GPT_4_1_MINI_2025_04_14), | ||
| default_factory=lambda: LLMModelConfig( | ||
| deployment=LLMModelsEnum.GPT_5_MINI_2025_08_07, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we can try gpt-5.4-mini
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. for sure |
||
| reasoning_effort=ReasoningEffortEnum.MINIMAL, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why not reasoning=none?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. there is no none reasoning for mini |
||
| verbosity=VerbosityEnum.LOW, | ||
| temperature=1, | ||
| ), | ||
| ) | ||
| harmonize_model_config: LLMModelConfig = Field( | ||
| description="LLM Model used for harmonization", | ||
| default_factory=lambda: LLMModelConfig(deployment=LLMModelsEnum.GPT_4_1_MINI_2025_04_14), | ||
| default_factory=lambda: LLMModelConfig( | ||
| deployment=LLMModelsEnum.GPT_5_MINI_2025_08_07, | ||
| reasoning_effort=ReasoningEffortEnum.MINIMAL, | ||
| verbosity=VerbosityEnum.LOW, | ||
| temperature=1, | ||
|
Comment on lines
+188
to
+191
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same. can try gpt-5.4-mini and none reasoning |
||
| ), | ||
| ) | ||
|
|
||
| # ~~~~~~~~~~ Search config ~~~~~~~~~~ | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,12 @@ | |
| from pydantic import Field | ||
| from pydantic_settings import BaseSettings, SettingsConfigDict | ||
|
|
||
| from statgpt.common.config.llm_models import EmbeddingModelsEnum, LLMModelsEnum | ||
| from statgpt.common.config.llm_models import ( | ||
| EmbeddingModelsEnum, | ||
| LLMModelsEnum, | ||
| ReasoningEffortEnum, | ||
| VerbosityEnum, | ||
| ) | ||
|
|
||
|
|
||
| class LangChainSettings(BaseSettings): | ||
|
|
@@ -38,6 +43,16 @@ class LangChainSettings(BaseSettings): | |
| description="Default seed for reproducible outputs", | ||
| ) | ||
|
|
||
| default_reasoning_effort: ReasoningEffortEnum | None = Field( | ||
| default=ReasoningEffortEnum.NONE, | ||
| description="Default reasoning effort for GPT-5 models (none/minimal/low/medium/high/xhigh)", | ||
| ) | ||
|
|
||
| default_verbosity: VerbosityEnum | None = Field( | ||
| default=VerbosityEnum.LOW, | ||
| description="Default verbosity for GPT-5 models (low/medium/high). None means use model default.", | ||
| ) | ||
|
|
||
|
Comment on lines
+46
to
+55
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. are those ever used? |
||
| # Debugging settings | ||
| verbose: bool = Field(default=False, description="Enable verbose mode for LangChain") | ||
|
|
||
|
|
||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. all changes to this whole file look stale. need to remove them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's fix to timeouts we had during indexing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Fedir-Yatsenko are you okay with this? looks like it affects all background jobs, not only indexing ones
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, this is okay