Go to definition, but with Ctrl + Click#437
Conversation
|
Just to mention, Ctrl+Click is open for use. I just want to make you aware that Ctrl+DoubleClick is taken already by the source editor widgets. |
fd73c6d to
e461384
Compare
|
this should be merged after #402 |
|
After merging #402 , it looks like this MR has conflicts. |
I'll check it |
e461384 to
872f578
Compare
|
@epasveer |
|
Thanks. Will do. |
6bea1ed to
ac1f07a
Compare
|
I fixed the issue, please review |
56caf7c to
f850e2d
Compare
|
Looks good and works. I've updated the help screen for the SeerEditorManagerWidget. If there's nothing else, I think I can pull it. |
|
That's all |
I may have merged it too soon. It appears your use of Ctrl+Click breaks the feature of adding variables to the Variable logger using Double Ctrl+Click. Can we change your feature to use Alt+Click instead? |
Disagree. Alt+Click seems counterintuitive, I don't think users will love it I tried using this feature, but it only works if I Ctrl + double-click the grey area, right? Could you please confirm this? If so, Ctrl + Click (Go to Definition) doesn't affect Ctrl + Double-click, because Ctrl + Click is only applied to SeerEditorWidgetSourceArea::mousePressEvent, while Ctrl + double-click is only applied to SeerEditorWidgetSourceLineNumberArea::mouseDoubleClickEvent |
As the title suggests