Skip to content

Go to definition, but with Ctrl + Click#437

Merged
epasveer merged 2 commits into
epasveer:mainfrom
QuangNguyenMinh123:feature/Go_to_definition_Ctrl_Click
Mar 21, 2026
Merged

Go to definition, but with Ctrl + Click#437
epasveer merged 2 commits into
epasveer:mainfrom
QuangNguyenMinh123:feature/Go_to_definition_Ctrl_Click

Conversation

@QuangNguyenMinh123
Copy link
Copy Markdown
Contributor

As the title suggests

@epasveer
Copy link
Copy Markdown
Owner

Just to mention, Ctrl+Click is open for use. I just want to make you aware that Ctrl+DoubleClick is taken already by the source editor widgets.

Keys
----
The easiest method for logging a variable to the Variable Logger is to double-click the variable text in the source. When doing this, a key modifier (shift and/or ctrl) can be used to prepend a '*' and/or '&' to the variable. This will better handle pointers and references.
      Double-Click
      Modifier      Description                           Example
      ------------  ------------------------------------  -----------------------
      None          No modifier is prepended to variable  'argc'
      Shift Key     Prepend '&' to variable               '&argc'
      Ctrl Key      Prepend '*' to variable               '*argc'
      Ctrl+Shift    Prepend '*&' to variable              '*&argc'

@QuangNguyenMinh123 QuangNguyenMinh123 force-pushed the feature/Go_to_definition_Ctrl_Click branch from fd73c6d to e461384 Compare February 25, 2026 18:10
@QuangNguyenMinh123 QuangNguyenMinh123 marked this pull request as ready for review February 25, 2026 18:11
@QuangNguyenMinh123
Copy link
Copy Markdown
Contributor Author

this should be merged after #402

@epasveer
Copy link
Copy Markdown
Owner

@QuangNguyenMinh123

After merging #402 , it looks like this MR has conflicts.

@QuangNguyenMinh123
Copy link
Copy Markdown
Contributor Author

@QuangNguyenMinh123

After merging #402 , it looks like this MR has conflicts.

I'll check it

@QuangNguyenMinh123 QuangNguyenMinh123 force-pushed the feature/Go_to_definition_Ctrl_Click branch from e461384 to 872f578 Compare March 19, 2026 17:00
@QuangNguyenMinh123 QuangNguyenMinh123 marked this pull request as draft March 19, 2026 17:07
@QuangNguyenMinh123
Copy link
Copy Markdown
Contributor Author

@epasveer
Please give this MR a try.
It might work, but it still needs a lot of improvement

@epasveer
Copy link
Copy Markdown
Owner

Thanks. Will do.

@QuangNguyenMinh123 QuangNguyenMinh123 force-pushed the feature/Go_to_definition_Ctrl_Click branch from 6bea1ed to ac1f07a Compare March 19, 2026 17:57
@QuangNguyenMinh123 QuangNguyenMinh123 marked this pull request as ready for review March 19, 2026 18:03
@QuangNguyenMinh123
Copy link
Copy Markdown
Contributor Author

I fixed the issue, please review

@QuangNguyenMinh123 QuangNguyenMinh123 marked this pull request as draft March 20, 2026 14:22
@QuangNguyenMinh123 QuangNguyenMinh123 force-pushed the feature/Go_to_definition_Ctrl_Click branch from 56caf7c to f850e2d Compare March 21, 2026 07:05
@QuangNguyenMinh123 QuangNguyenMinh123 marked this pull request as ready for review March 21, 2026 07:06
@epasveer
Copy link
Copy Markdown
Owner

Looks good and works. I've updated the help screen for the SeerEditorManagerWidget.

If there's nothing else, I think I can pull it.

@QuangNguyenMinh123
Copy link
Copy Markdown
Contributor Author

That's all

@epasveer epasveer merged commit 25659d7 into epasveer:main Mar 21, 2026
1 check passed
@epasveer
Copy link
Copy Markdown
Owner

epasveer commented Mar 21, 2026

@QuangNguyenMinh123

Just to mention, Ctrl+Click is open for use. I just want to make you aware that Ctrl+DoubleClick is taken already by the source editor widgets.

I may have merged it too soon.

It appears your use of Ctrl+Click breaks the feature of adding variables to the Variable logger using Double Ctrl+Click.

Can we change your feature to use Alt+Click instead?

@QuangNguyenMinh123
Copy link
Copy Markdown
Contributor Author

change your feature to use Alt+Click instead

Disagree. Alt+Click seems counterintuitive, I don't think users will love it
BTW, I see this on CHANGELOG.md:

## [2.3] - 2023-11-19
* In the margins of the source windows, allow CTRL+DoubleClick to do a quick RunToLine or RunToAddress.

I tried using this feature, but it only works if I Ctrl + double-click the grey area, right? Could you please confirm this?

If so, Ctrl + Click (Go to Definition) doesn't affect Ctrl + Double-click, because Ctrl + Click is only applied to SeerEditorWidgetSourceArea::mousePressEvent, while Ctrl + double-click is only applied to SeerEditorWidgetSourceLineNumberArea::mouseDoubleClickEvent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants