Add offset and stride to ImPlotGetter plots #609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for downsampling ImPlotGetter plots!
|
Thank you for this change, I hope this can be merged upstream. |
brenocq
added
type:feat
brenocq
requested changes
Dec 21, 2025
Collaborator
brenocq
left a comment
brenocq
left a comment
There was a problem hiding this comment.
Hi @GameChaos! Thanks for working on this feature. I left a small comment regarding the name change.
I recommend also modifying the Demo_CustomDataAndGetters in implot_demo.cpp to showcase your feature :)
| IMPLOT_TMP void PlotLine(const char* label_id, const T* values, int count, double xscale=1, double xstart=0, ImPlotLineFlags flags=0, int offset=0, int stride=sizeof(T)); | ||
| IMPLOT_TMP void PlotLine(const char* label_id, const T* xs, const T* ys, int count, ImPlotLineFlags flags=0, int offset=0, int stride=sizeof(T)); | ||
| IMPLOT_API void PlotLineG(const char* label_id, ImPlotGetter getter, void* data, int count, ImPlotLineFlags flags=0); | ||
| IMPLOT_API void PlotLineG(const char* label_id, ImPlotGetter getter, void* data, int count, ImPlotLineFlags flags=0, int offset=0, int stride=1); // offset and stride aren't in bytes, they act on the index, ie: idx * offset + stride |
Collaborator
There was a problem hiding this comment.
I agree using offset/stride can be a bit misleading, I would recommend idx_offset/idx_stride here
brenocq
reviewed
Dec 21, 2025
| { } | ||
| template <typename I> IMPLOT_INLINE ImPlotPoint operator()(I idx) const { | ||
| return Getter(idx, Data); | ||
| return Getter(idx * Stride + Offset, Data); |
Collaborator
There was a problem hiding this comment.
To be consistent with the byte-wise offset/stride, it would be better to do something like (idx * Stride + Offset) % Count.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for downsampling ImPlotGetter plots, like the "Time Series" demo in implot_demo.cpp.
Stride and offset don't feel like the right words though, because instead of being a byte offset/stride, they offset/stride the index instead.
Some code I've used this for (apologies in advance): https://codeberg.org/GameChaos/amogus/src/commit/e176744987894a8938b59c6a6124938b7f4cdde4/code/amogus.cpp#L1582-L1597