Changed Field Fix #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anjohnson
reviewed
May 1, 2024
| @@ -289,6 +289,7 @@ static void testMasterField(PVRecordPtr const& pvRecord) | |||
| cout << "Master PV structure from copy" << endl << *pvMasterField << endl; | |||
| cout << "Master PV structure from copy offset " << pvMasterField->getFieldOffset() << endl; | |||
| } | |||
| testOk1(pvCopy->isMasterFieldRequested()); | |||
There was a problem hiding this comment.
This only appears to test that PVCopy detects when the master field is requested, showing the changes to PVCopy and pvRecord. How about adding tests for the behavior fix described in the intro to this PR, which appears to have been implemented in MonitorLocal::dataPut()?
There was a problem hiding this comment.
New set of tests have been added that verify correct behavior of the changed set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue with changed field set in the case where the top level (master) field ("_") is not requested by the client, but the master field callback causes all fields to be marked as updated, rather than only those fields that have actually been modified. The example below shows how the code works with this PR: the PV structure contains 4 fields, with the field 'z' the only one not being updated on the server side, and this is indicated correctly using pvmonitor and printing only fields that changed (after the initial update):
$ pvmonitor -m -r '' -v a a structure int x 89 int y 178 float z 0 int i 2 a structure int x 69 int y 138 int i 3 a structure int x 39 int y 78 int i 4Without this fix, all fields would be marked as updated.