Conversation
The binaryErrorCheck method now does a more thorough validation of the reply from the controller. It checks the following: * reply length * command prefix/suffix * body start/end characters * error number characters All of the checks must pass for the message to be determined to be an error message.
…s the error number, but not the human-readable error string.
…ide binaryErrorCheck
…ks but still causes deadlocks when called from binaryErrorCheck for unknown reasons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Significantly improved binary error checking so that messages that happen to have "?" and "\r" in the same locations of the reply as error messages are no longer incorrectly interpreted as error messages with invalid error numbers. Human-readable error strings are now printed along with the error number when real errors occur.
Fixes #72