-
Notifications
You must be signed in to change notification settings - Fork 103
feat: secure biometric implementation #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lubbo
wants to merge
10
commits into
epicshaggy:master
Choose a base branch
from
lubbo:feat/secure-biometric-implementation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: secure biometric implementation #89
lubbo
wants to merge
10
commits into
epicshaggy:master
from
lubbo:feat/secure-biometric-implementation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0550bc5.
|
Bump on this 🙏 |
|
Hey @lubbo we do have a fork of this plugin here: https://github.com/Cap-go/capacitor-native-biometric who is maintained and we are interest to get your PR merged are you able to help? |
3 tasks
Author
Absolutely yes! |
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Get and Set credentials were not enforcing biometric encryption.
Solution
Android
https://medium.com/androiddevelopers/using-biometricprompt-with-cryptoobject-how-and-why-aace500ccdb7
iOS
https://developer.apple.com/documentation/localauthentication/accessing_keychain_items_with_face_id_or_touch_id
Additional changes
serverparameter)Android
AuthActivityhas been created and all non UI logic has been moved there.Credentialsclass model has been created with from/to JSON utilities.CryptoManager.getCredentialsresponse is passed from Activity toNativeBiometricPlugin using aLocalBroadcastManager.iOS
CryptoManagerclass